Skip to content

bpo-45953: Statically allocate and initialize global bytes objects.#30096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 7 commits into from
Jan 11, 2022
Merged

bpo-45953: Statically allocate and initialize global bytes objects. #30096

ericsnowcurrently merged 7 commits into from
Jan 11, 2022

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commented Dec 14, 2021•
edited by bedevere-bot
Loading

The empty bytes object (b'') and the 256 one-character bytes objects are allocated at runtime init. Here we statically allocate and initialize them.

https://bugs.python.org/issue45953

@ericsnowcurrentlyericsnowcurrently mentioned this pull request Dec 14, 2021
Closed
markshannon
markshannon reviewed Dec 14, 2021
View reviewed changes
markshannon
markshannon reviewed Dec 14, 2021
View reviewed changes
markshannon
markshannon reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quibbles, otherwise looks good.

Include/internal/pycore_global_objects.h
.ob_shash = -1, \
.ob_sval[0] = '\0', \
}
#define_PyBytes_CHAR_INIT(CH) \
Copy link
Member

@markshannonmarkshannonJan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a declaration, not initialization code. Maybe rename to _PyBytes_CHAR?

Copy link
MemberAuthor

@ericsnowcurrentlyericsnowcurrentlyJan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sticking to the _INIT convention used elsewhere.

@ericsnowcurrentlyericsnowcurrently merged commit cf496d6 into python:mainJan 11, 2022
@ericsnowcurrentlyericsnowcurrently deleted the global-objects-bytes branch January 11, 2022 16:37
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Nov 8, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum left review comments

@markshannonmarkshannonmarkshannon left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericsnowcurrently@gvanrossum@markshannon@the-knights-who-say-ni@bedevere-bot