Skip to content

Conversation

@jmarshall
Copy link
Contributor

@jmarshalljmarshall commented Dec 16, 2021

This addresses bpo-45554 by expanding the exitcode documentation to also describe what exitcode will be in cases of normal termination, sys.exit() called, and on uncaught exceptions.

https://bugs.python.org/issue45554

Automerge-Triggered-By: GH:pitrou

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Jan 16, 2022
@zwarezware removed the stale Stale PR or inactive for long period of time. label Jan 18, 2022
@zwarezware requested review from applio and pitrouJanuary 18, 2022 21:18
Copy link
Member

@pitroupitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thanks for the PR, this looks entirely good to me.

@miss-islington
Copy link
Contributor

@jmarshall: Status check is done, and it's a success ✅ .

@miss-islingtonmiss-islington merged commit 3852269 into python:mainJan 18, 2022
@miss-islington
Copy link
Contributor

Thanks @jmarshall for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
…-30142) This addresses [bpo-45554]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions. Automerge-Triggered-By: GH:pitrou (cherry picked from commit 3852269) Co-authored-by: John Marshall <jmarshall@hey.com>
@bedevere-bot
Copy link

GH-30674 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
…-30142) This addresses [bpo-45554]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions. Automerge-Triggered-By: GH:pitrou (cherry picked from commit 3852269) Co-authored-by: John Marshall <jmarshall@hey.com>
@bedevere-bot
Copy link

GH-30675 is a backport of this pull request to the 3.9 branch.

@jmarshall
Copy link
ContributorAuthor

Thanks @zware and @pitrou for taking the time to review this. 🎉

miss-islington added a commit that referenced this pull request Jan 18, 2022
This addresses [bpo-45554]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions. Automerge-Triggered-By: GH:pitrou (cherry picked from commit 3852269) Co-authored-by: John Marshall <jmarshall@hey.com>
miss-islington added a commit that referenced this pull request Jan 18, 2022
…-30142) (GH-30675) This addresses [[bpo-45554]()]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions. (cherry picked from commit 3852269) Co-authored-by: John Marshall <jmarshall@hey.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…thonGH-30142) (pythonGH-30675) This addresses [[bpo-45554]()]() by expanding the `exitcode` documentation to also describe what `exitcode` will be in cases of normal termination, `sys.exit()` called, and on uncaught exceptions. (cherry picked from commit 3852269) Co-authored-by: John Marshall <jmarshall@hey.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jmarshall@miss-islington@bedevere-bot@pitrou@sobolevn@zware@the-knights-who-say-ni