bpo-38415: Remove redundant AsyncContextDecorator.__call__ override from _AsyncG…#30233
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…eneratorContextManager
graingert changed the title 
graingert commented Dec 23, 2021
Misc/NEWS.d/next/Library/2021-12-23-00-58-31.bpo-38415.NY5sUF.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
graingert commented Dec 23, 2021
Misc/NEWS.d/next/Library/2021-12-23-00-58-31.bpo-38415.NY5sUF.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka changed the title Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka approved these changes Dec 26, 2021
Uh oh!
There was an error while loading. Please reload this page.
raghavthind2005 approved these changes Jan 23, 2022
Since the change does not affect the user-visible behavior, a NEWS entry is not needed.
serhiy-storchaka approved these changes Feb 3, 2022
serhiy-storchaka approved these changes Feb 26, 2022
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
…rom _AsyncGeneratorContextManager (GH-30233)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eneratorContextManager
#16667 was opened however was allowed to go stale while #20516 was created and then merged first.
This PR currently shows that the tests added in #16667 pass without the associated code change - but it might be cleaner to just do a plain revert and rely on the tests added in #20516
https://bugs.python.org/issue38415