Skip to content

bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy.#30289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 9 commits into from
Jan 2, 2022
Merged

bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. #30289

iritkatriel merged 9 commits into from
Jan 2, 2022

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commented Dec 29, 2021•
edited
Loading

The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change.

Otherwise, this just moves code from ceval.c to exceptions.c and sets me up to get a notification for PRs touching exceptions and tracebacks.

https://bugs.python.org/issue46221

https://bugs.python.org/issue46219

iritkatriel
iritkatriel commented Dec 29, 2021
View reviewed changes
@iritkatrieliritkatriel marked this pull request as draft December 30, 2021 11:55
@iritkatrieliritkatriel changed the title bpo-45711: simplify except star implementation following exc_info changes. Move PREP_RERAISE_STAR helpers to exceptions.cbpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy.Jan 1, 2022
@iritkatrieliritkatriel marked this pull request as ready for review January 1, 2022 14:37
@iritkatriel
Copy link
MemberAuthor

iritkatriel commented Jan 2, 2022

@erlend-aasland would you have time to review this? It’s mostly moving code from ceval.c to exceptions.c. Would be nice to get it into the next alpha release (due to be cut tomorrow) so it gets tested in close to final form.

erlend-aasland
erlend-aasland approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the changes in ceval and the compiler with good help from Irit. LGTM. Moving exception helpers to exception.c is a nice "cleanup".

@iritkatriel
Copy link
MemberAuthor

iritkatriel commented Jan 2, 2022

Thank you @erlend-aasland, @brandtbucher and @ericsnowcurrently for the reviews (on this an on PR30302 which contained the functional changes in this PR).

@iritkatrieliritkatriel merged commit 65e7c1f into python:mainJan 2, 2022
@iritkatrieliritkatriel deleted the simplify-except-star branch January 13, 2022 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@erlend-aasland@the-knights-who-say-ni@bedevere-bot