Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-40479: Fix hashlib's usedforsecurity for OpenSSL 3.0.0 (GH-30455)#30455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
tiran commented Jan 7, 2022 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tomato42 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check if the property flags are used correctly, they are, so it should work fine in real FIPS mode with a real FIPS module
didn't really review any other part
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Jan 7, 2022
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be put in the comfy chair! |
tiran commented Jan 8, 2022
I have made the requested changes; please review again |
bedevere-bot commented Jan 8, 2022
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
gpshead left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good, though you've got a leftover debugging #if 1 in the code...
Uh oh!
There was an error while loading. Please reload this page.
miss-islington commented Jan 13, 2022
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington commented Jan 13, 2022
Sorry, @tiran, I could not cleanly backport this to |
bedevere-bot commented Jan 13, 2022
GH-30573 is a backport of this pull request to the 3.10 branch. |
…honGH-30455). (cherry picked from commit 443b308) Co-authored-by: Christian Heimes <christian@python.org>
bedevere-bot commented Jan 13, 2022
GH-30574 is a backport of this pull request to the 3.9 branch. |
bedevere-bot commented Jan 13, 2022
|
pablogsal commented Jan 13, 2022
@tiran This stable buildbot started to fail with this PR. Can you take a look? |
https://bugs.python.org/issue40479