bpo-46307: Add string.Template.get_identifiers() method

[benkehoe]

Add string.Template.get_identifiers() method that returns the identifiers within the template. By default, raises an error if it encounters an invalid identifier (like substitute()). The keyword-only argument raise_on_invalid can be set to False to ignore invalid identifiers (like safe_substitute()).

https://bugs.python.org/issue46307

Automerge-Triggered-By: GH:warsaw

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@benkehoe

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[sobolevn]

Hi! Thanks for the patch!

Since this is your first PR to CPython, you would need to:

• Sign CLA agreement, just follow the process in the reply above. If you have any questions - feel free to ping me 🙂
• Add NEWS entry. With https://blurb-it.herokuapp.com/ or CLI tool: https://github.com/larryhastings/blurb

[warsaw]

Thanks for creating this PR!

Please be sure to update the string module's documentation too!

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[benkehoe]

I have made the requested changes; please review again

[bedevere-bot]

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[warsaw]

@benkehoe Have you signed the CLA?

[benkehoe]

Do I need to put .. versionadded:: 3.11 on the new methods? I have signed the CLA. I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

[warsaw]

Do I need to put .. versionadded:: 3.11 on the new methods?

Yes, please. Sorry, I should have mentioned that earlier.

[benkehoe]

Added the versionadded info to the docs.

[warsaw]

Thanks @benkehoe for working on this! I'm approving it. I've also set CI to run and automerge label, so if that passes, this should land.

[benkehoe]

Awesome! Thanks @warsaw for helping me make my first contribution to Python!

[miss-islington]

@benkehoe: Status check is done, and it's a success ✅ .

[warsaw]

Well done @benkehoe !