Skip to content

Conversation

@tiran
Copy link
Member

@tirantiran commented Jan 9, 2022

  • add check for HAVE_CLOCK
  • use HAVE_PTHREAD_H to guard include of pthread.h
  • guard getpid() with HAVE_GETPID
  • guard clock() with HAVE_CLOCK
  • add checks for HAVE_UMASK and HAVE_CHMOD
  • guard include of setjmp.h
  • use signal emulation on WASI

https://bugs.python.org/issue46315

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* add check for HAVE_CLOCK * use HAVE_PTHREAD_H to guard include of pthread.h * guard getpid() with HAVE_GETPID * guard clock() with HAVE_CLOCK * add checks for HAVE_UMASK and HAVE_CHMOD * guard include of setjmp.h * use signal emulation on WASI
@tirantiran changed the title bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibilitybpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507)Jan 13, 2022
@tirantiran merged commit a6ca8ee into python:mainJan 13, 2022
@tirantiran deleted the bpo-46315-wasi branch January 13, 2022 08:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@erlend-aasland@the-knights-who-say-ni@bedevere-bot