bpo-46345: add a test case for implicit Optional class attribute#30535
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fidget-Spinner approved these changes Jan 12, 2022
Member
Fidget-Spinner left a comment
Fidget-Spinner left a comment There was a problem hiding this comment.
LGTM. Do you suggest we backport this?
JelleZijlstra approved these changes Jan 12, 2022
MemberAuthor
sobolevn commented Jan 12, 2022
Thanks for the review! 👍 I think it is safe to backport to 3.10 and 3.9 |
gvanrossum approved these changes Jan 12, 2022
gvanrossum approved these changes Jan 12, 2022
Member
gvanrossum commented Jan 12, 2022
Looks like the issue-number bot is stuck. Closing and reopening to restart it (sigh). |
Contributor
miss-islington commented Jan 12, 2022
Thanks @sobolevn for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
bedevere-bot commented Jan 12, 2022
GH-30567 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2022
…ythonGH-30535) (cherry picked from commit 1de6015) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2022
…ythonGH-30535) (cherry picked from commit 1de6015) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
bedevere-bot commented Jan 12, 2022
GH-30568 is a backport of this pull request to the 3.9 branch. |
MemberAuthor
sobolevn commented Jan 13, 2022
Thanks everyone! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #30304
CC @corona10 as my mentor
https://bugs.python.org/issue46345