Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jan 12, 2022

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.

https://bugs.python.org/issue36854

…rState (GH-17287)" This reverts commit 7247407. Fix a random crash involving subinterpreters on Windows. Revert the change which made the gc module state per interpreter: the gc module state is shared again by all interpreters.
@vstinnervstinner changed the title [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"bpo-46070: [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"Jan 12, 2022
Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner changed the title bpo-46070: [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"[3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"Jan 13, 2022
@vstinner
Copy link
MemberAuthor

I wrote a simpler fix: GH-30577.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@ericsnowcurrently@the-knights-who-say-ni@bedevere-bot