Skip to content

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615)#30615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiran merged 1 commit into from
Jan 25, 2022
Merged

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) #30615

tiran merged 1 commit into from
Jan 25, 2022

Conversation

@tiran
Copy link
Member

@tirantiran commented Jan 15, 2022•
edited by bedevere-bot
Loading

kumaraditya303
kumaraditya303 reviewed Jan 15, 2022
View reviewed changes
@tirantiranforce-pushed the bpo-40280-test-subprocess branch from e61311a to 87fd2feCompareJanuary 16, 2022 22:03
emmatyping
emmatyping reviewed Jan 17, 2022
View reviewed changes
@tirantiranforce-pushed the bpo-40280-test-subprocess branch 2 times, most recently from 61decef to 8c9097eCompareJanuary 21, 2022 15:38
@tirantiranforce-pushed the bpo-40280-test-subprocess branch from 8c9097e to d20fdb2CompareJanuary 24, 2022 08:19
@tirantiran marked this pull request as ready for review January 24, 2022 08:52
gpshead
gpshead reviewed Jan 24, 2022
View reviewed changes
emmatyping
emmatyping approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@tirantiran changed the title bpo-40280: Skip subprocess-based tests on wasm32-emscriptenbpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615)Jan 25, 2022
@tirantiran merged commit 8464fbc into python:mainJan 25, 2022
@tirantiran deleted the bpo-40280-test-subprocess branch January 25, 2022 07:09
@SimonBiggsSimonBiggsmannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments

@gpsheadgpsheadgpshead approved these changes

@emmatypingemmatypingemmatyping approved these changes

@iritkatrieliritkatrielAwaiting requested review from iritkatriel

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran@gpshead@emmatyping@kumaraditya303@the-knights-who-say-ni@bedevere-bot