Skip to content

GH-73991: Add pathlib.Path.move that can handle rename across FS#30650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oz123 wants to merge 2 commits into from
Closed

GH-73991: Add pathlib.Path.move that can handle rename across FS #30650

oz123 wants to merge 2 commits into from

Conversation

@oz123
Copy link
Contributor

@oz123oz123 commented Jan 17, 2022•
edited by bedevere-bot
Loading

With this change, Pathlib.move adds the ability
to handle renaming across file system and also preserve metadata
when renaming, since shutil.move using shutil.copy2 is used
under the hood.

https://bugs.python.org/issue46317

https://bugs.python.org/issue46317

@oz123oz123force-pushed the bpo-46317-pathlib-move branch from b885731 to b3f4752CompareJanuary 17, 2022 19:48
@oz123oz123 changed the title bpo-46317: Add Pathlib.move that can handle rename across FSbpo-46317: Add pathlib.Path.move that can handle rename across FSJan 17, 2022
@oz123oz123force-pushed the bpo-46317-pathlib-move branch from b3f4752 to 673f1c9CompareJanuary 17, 2022 19:50
barneygale
barneygale reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@barneygalebarneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer metadata=True over copy_function=shutil.copy2, and would like to request a third opinion :-)

@oz123oz123force-pushed the bpo-46317-pathlib-move branch 2 times, most recently from 9d35c9a to b20e32fCompareJanuary 24, 2022 22:35
@oz123oz123force-pushed the bpo-46317-pathlib-move branch from b20e32f to 84157e1CompareFebruary 4, 2022 13:09
barneygale
barneygale reviewed Feb 5, 2022
View reviewed changes
@oz123oz123force-pushed the bpo-46317-pathlib-move branch from bb1a964 to 29dfb12CompareFebruary 5, 2022 23:21
@oz123
bpo-46317: Add pathlib.Path.move that can handle renaming across FS
8be5cdc
With this change, ``pathlib.Path.move`` adds the ability to handle renaming across file system and also preserve metadata when renaming, since ``shutil.move`` using ``shutil.copy2`` is used under the hood.
@oz123
Fix grammar: replace wrong an with a
edce418
@oz123oz123force-pushed the bpo-46317-pathlib-move branch from 29dfb12 to edce418CompareFebruary 6, 2022 20:22
MaxwellDupre
MaxwellDupre approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 462 tests in 3.520s
OK (skipped=137)
Added test passed. Looks ok.

@oz123oz123mannequin mentioned this pull request Jun 21, 2022
Closed
@ric-evansric-evans mentioned this pull request Oct 5, 2022
Merged
@barneygalebarneygale changed the title bpo-46317: Add pathlib.Path.move that can handle rename across FSGH-73991: Add pathlib.Path.move that can handle rename across FSApr 14, 2023
@bedevere-botbedevere-bot mentioned this pull request Apr 14, 2023
Closed
@barneygale
Copy link
Contributor

barneygale commented Aug 26, 2024

I'm going to close this PR because I've added a (different) implementation of move() in GH-122073. Thank you.

@oz123
Copy link
ContributorAuthor

oz123 commented Aug 26, 2024

Thanks for letting me know. I'm happy that the issue is finally resolved.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygalebarneygalebarneygale left review comments

+1 more reviewer

@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewtopic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@oz123@barneygale@MaxwellDupre@brettcannon@the-knights-who-say-ni@ezio-melotti@bedevere-bot