bpo-46443: deepfreeze use preallocated small ints#30715
Uh oh!
There was an error while loading. Please reload this page.
Conversation
kumaraditya303 commented Jan 20, 2022
It is an implementation detail so skip news. |
gvanrossum commented Jan 20, 2022
I don't think that's how we usually do this. We skip news for things like fixing typos in comments, but almost anything else gets a new entry. Maybe you're confused with "What's New in 3.11"? That definitely only should get the major visible items. |
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
LG except I would like to see a one-line news item.
Did you check how much space this saves? (Probably nut that much since ints are small.)
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 commented Jan 20, 2022
Ok, I'll add a news fragment. Should I create a bpo for this now ? |
gvanrossum commented Jan 20, 2022
Yeah. |
kumaraditya303 changed the title gvanrossum commented Jan 20, 2022
I recommend that you put a little more effort in writing the initial comment for the bpo issues you create. E.g. not just what to do, but why it's worth doing and what impact you expect. |
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Thanks! This was indeed super-simple. :-)
I would also do this for empty bytes object as that also has a global singleton. (DONE) |
gvanrossum commented Jan 20, 2022
Good idea. Maybe you can just add that to this PR, it's small enough. |
kumaraditya303 commented Jan 20, 2022
I was confused by this PR as it skipped news #30092 |
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Great! Now just waiting for CI to finish...
gvanrossum commented Jan 20, 2022
Different core devs have different standards... |
gvanrossum commented Jan 20, 2022
I'm the bot. :-) |
3 participants
https://bugs.python.org/issue46443