bpo-46425: fix direct invocation of asyncio tests#30725
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now some tests in
test_asyncioare suitable to be executed directly aspython Lib/test/test_asyncio/test_X.pyand some are only executable with-m testor-m Lib/test/test_asyncio.cpython/Lib/test/test_asyncio/test_asyncio_waitfor.py
Lines 60 to 61 in c02e860
cpython/Lib/test/test_asyncio/test_context.py
Lines 33 to 34 in c02e860
This does not look good to me.
So, I've fixed several tests modules in
test_asynciowhen invoked directly aspython module_name.pyThere were two major problems:
unittest.main()callThe best way to illustrate this problem is to show
Lib/test/test_asyncio/test_runners.py:Step 1. No changes.
Step 2. Fixed relative import.
(nothing happens)
Step 3. With
unottest.main():CC @corona10 as my mentor.
https://bugs.python.org/issue46425