bpo-40170: Remove PyHeapType_GET_MEMBERS() macro

[vstinner]

Remove the PyHeapType_GET_MEMBERS() macro. It was exposed in the
public C API by mistake, it must only be used by Python internally.
Use the PyTypeObject.tp_members member instead.

Rename PyHeapType_GET_MEMBERS() to _PyHeapType_GET_MEMBERS() and move
it to the internal C API.

https://bugs.python.org/issue40170

[vstinner]

A search for "PyHeapType_GET_MEMBERS" in top 5000 PyPI project returns no result: it doesn't seem to be used outside CPython internals.

cc @erlend-aasland@corona10

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 18ea973.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/881) and take a look at the build logs.
4. Check if the failure is related to this commit (18ea973) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/881

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

• test_concurrent_futures: 3 min 41 sec
• test_multiprocessing_spawn: 2 min 30 sec
• test_multiprocessing_forkserver: 1 min 48 sec
• test_unparse: 1 min 27 sec
• test_asyncio: 1 min 21 sec
• test_tokenize: 1 min 11 sec
• test_logging: 1 min 5 sec
• test_nntplib: 1 min 1 sec
• test_lib2to3: 54.1 sec
• test_capi: 53.2 sec

1 test altered the execution environment:
test_ftplib

17 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_ioctl
test_msilib test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 10 min 11 sec

Click to see traceback logs

Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main cache[rtype].remove(name) ^^^^^^^^^^^^^^^^^^^^^^^^^KeyError: '/psm_7023f3cf' Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read obj.handle_read_event() ^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_eventself._do_ssl_handshake() ^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshakeself.socket.do_handshake() ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1345, in do_handshakeself._sslobj.do_handshake() ^^^^^^^^^^^^^^^^^^^^^^^^^^^ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998) Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_innerself.run() ^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run asyncore.loop(timeout=0.1, count=1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop poll_fun(timeout, map) ^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll read(obj) ^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read obj.handle_error() ^^^^^^^^^^^^^^^^^^ File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_errorraiseException^^^^^^^^^^^^^^^ Exception k Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main cache[rtype].remove(name) ^^^^^^^^^^^^^^^^^^^^^^^^^KeyError: '/psm_fd07fa2a'

[ghost]

A search for "PyHeapType_GET_MEMBERS" in top 5000 PyPI project returns no result: it doesn't seem to be used outside CPython internals.

cc @erlend-aasland@corona10

It doesn't seem like PyTorch is below top-5000 projects, but still using PyHeapType_GET_MEMBERS.

This is why I have to re-add this macro either inside Pytorch or revert deletion commit.

[vstinner]

It doesn't seem like PyTorch is below top-5000 projects, but still using PyHeapType_GET_MEMBERS. This is why I have to re-add this macro either inside Pytorch or revert deletion commit.

Please open a new issue for that. Please explain why PyTorch requires this function and elaborate on how it is used in PyTorch. Honestly, I don't understand the purpose of this function :-D

[vstinner]

What's New in Python 3.11 says:

Remove the PyHeapType_GET_MEMBERS() macro. It was exposed in the
public C API by mistake, it must only be used by Python internally.
Use the PyTypeObject.tp_members member instead.

Can you please elaborate why using the PyTypeObject.tp_members member doesn't fit PyTorch requirements?