Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Feb 3, 2022

Fix command-line option -d/--directory in http.server main
function that was ignored when combined with --cgi.

Automerge-Triggered-By: GH:merwok
(cherry picked from commit 2d08034)

Co-authored-by: Géry Ogam gery.ogam@gmail.com

https://bugs.python.org/issue46436

Automerge-Triggered-By: GH:merwok

…er (pythonGH-30701) Fix command-line option -d/--directory in http.server main function that was ignored when combined with --cgi. Automerge-Triggered-By: GH:merwok (cherry picked from commit 2d08034) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@miss-islington
Copy link
ContributorAuthor

@maggyero: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
ContributorAuthor

@maggyero: Status check is done, and it's a success ✅ .

@merwokmerwok self-assigned this Feb 3, 2022
@miss-islington
Copy link
ContributorAuthor

@maggyero: Status check is done, and it's a success ✅ .

@merwok
Copy link
Member

@raghavthind2005 Please add a comment with approvals to explain what you did (reviewed the code, built python and ran the tests, reviewed the bug report, etc). Otherwise these drive-by approvals provide zero value and only add fake activity to your profile (and people looking at it can tell that these are not real contributions).

@geryogam
Copy link
Contributor

Thanks @raghavthind2005 but I concur with @merwok, could you comment about what you did?

@MariattaMariatta merged commit 502ad39 into python:3.9Feb 14, 2022
@miss-islingtonmiss-islington deleted the backport-2d08034-3.9 branch February 14, 2022 20:12
@geryogam
Copy link
Contributor

Thanks @Mariatta!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@miss-islington@merwok@geryogam@raghavthind2005@Mariatta@the-knights-who-say-ni@bedevere-bot