Skip to content

bpo-46709: check eval breaker in specialized CALL opcodes#31404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 3 commits into from
Feb 18, 2022
Merged

bpo-46709: check eval breaker in specialized CALL opcodes #31404

markshannon merged 3 commits into from
Feb 18, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Feb 18, 2022•
edited
Loading

Changes:

  1. I've added CHECK_EVAL_BREAKER() to all specialized opcodes. This needs to be double checked
  2. I've added withRepeats() helper test method to run the test case several times. They were failing before CHECK_EVAL_BREAKER() additions, but now they pass!

Replaces:

Bugs:

https://bugs.python.org/issue46709

https://bugs.python.org/issue46465

@markshannon
Copy link
Member

markshannon commented Feb 18, 2022

What's the race?

markshannon
markshannon reviewed Feb 18, 2022
View reviewed changes
markshannon
markshannon reviewed Feb 18, 2022
View reviewed changes
markshannon
markshannon reviewed Feb 18, 2022
View reviewed changes
markshannon
markshannon reviewed Feb 18, 2022
View reviewed changes
@sobolevnsobolevn changed the title bpo-46709: fix race conditions in unittest/test_brakebpo-46709: check eval breaker in specialized CALL opcodesFeb 18, 2022
@sobolevn
Copy link
MemberAuthor

sobolevn commented Feb 18, 2022

Thank you! Removed extra ones. 👍

What's the race?

Sorry, this was from the #31273, new wording should be better.

@markshannon
Copy link
Member

markshannon commented Feb 18, 2022

Thanks for picking this up.

@markshannonmarkshannon merged commit e2c2861 into python:mainFeb 18, 2022
@vstinnervstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon left review comments

@vstinnervstinnerAwaiting requested review from vstinner

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@markshannon@the-knights-who-say-ni@bedevere-bot