Skip to content

bpo-46752: Taskgroup tweaks#31559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 1 commit into from
Feb 26, 2022
Merged

bpo-46752: Taskgroup tweaks #31559

gvanrossum merged 1 commit into from
Feb 26, 2022

Conversation

@Tinche
Copy link
Contributor

@TincheTinche commented Feb 25, 2022•
edited by bedevere-bot
Loading

Here are some taskgroup tweaks, mostly from the cancellation changes and @gvanrossum 's comments in #31513 (comment).

  • check the return value of .uncancel() to decide whether to propagate the CancelledError
  • propagate the CancelledError exception properly in some cases
  • _abort() only once, instead of potentially multiple times (unsure if it could've happened in reality)
  • renamed a couple of tests that I worked on to be a little more descriptive

https://bugs.python.org/issue46752

gvanrossum
gvanrossum approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unless @asvetlov or @1st1 peeps I'll merge this in a day or so.

kumaraditya303
kumaraditya303 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossumgvanrossum merged commit edbee56 into python:mainFeb 26, 2022
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
@Tinche@asvetlov
Taskgroup tweaks (GH-31559)
10f07fb
Now uses .cancel()/.uncancel(), for even fewer broken edge cases.
@gvanrossumgvanrossum mentioned this pull request Apr 27, 2022
Closed
@gvanrossumgvanrossum mentioned this pull request Aug 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tinche@gvanrossum@kumaraditya303@the-knights-who-say-ni@bedevere-bot