bpo-46857: Fix test_embed.test_no_memleak() on Windows#31589
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Tolerate a leak of 1 reference and 1 memory block until it's fixed.
kumaraditya303 approved these changes Feb 25, 2022
Contributor
kumaraditya303 left a comment
kumaraditya303 left a comment There was a problem hiding this comment.
LGTM, I'll try to find the leak but till then it is good enough.
MemberAuthor
vstinner commented Feb 25, 2022
Good luck! It can be a bug which exists for many years. See for example my winreg.c fix, it was an old bug. |
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
Tolerate a leak of 1 reference and 1 memory block until it's fixed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tolerate a leak of 1 reference and 1 memory block until it's fixed.
https://bugs.python.org/issue46857