Skip to content

CI: Fix patchcheck#31708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asvetlov merged 2 commits into from
Mar 14, 2022
Merged

CI: Fix patchcheck #31708

asvetlov merged 2 commits into from
Mar 14, 2022

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Mar 6, 2022•
edited
Loading

patchcheck was erroring on the CI but not reporting as a failure. It wasn't not actually checking any files:

Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/main': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' 0 files

Two fixes here:

  • Make errors noisy: report then non-zero exit
  • Fix the error: CI was in detached HEAD, need to git fetch origin so it has access to diff origin/main

@hugovkhugovkforce-pushed the test-patchcheck branch 3 times, most recently from 97f9e1c to 363fb93CompareMarch 6, 2022 19:46
@hugovkhugovk changed the title TEMP debugging pathcheckCI: Fix patchcheckMar 6, 2022
@hugovkhugovk marked this pull request as ready for review March 6, 2022 21:27
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 6, 2022

https://dev.azure.com/Python/cpython/_build/results?buildId=98028&view=logs&j=256d7e09-002a-52d7-8661-29ee3960640e&t=3d7276d3-4e8d-5309-55ad-fb0b172d9925 looks good

@asvetlovasvetlov merged commit 23abae6 into python:mainMar 14, 2022
@asvetlov
Copy link
Contributor

asvetlov commented Mar 14, 2022

Thanks!

@hugovkhugovk deleted the test-patchcheck branch March 14, 2022 13:32
@hugovkhugovk mentioned this pull request Mar 14, 2022
Closed
carljm pushed a commit to carljm/cpython that referenced this pull request Mar 14, 2022
Merge branch 'main' into dictwatch
d22463b
* main: (94 commits) Revert "bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)" (pythonGH-31879) bpo-30677: [doc] mention that os.mkdir() can raise FileNotFoundError (pythonGH-31548) git ignore Lib/site-packages (pythonGH-31862) bpo-31415: importtime was made by Inada Naoki (pythonGH-31875) bpo-46920: Remove code that has explainers why it was disabled (pythonGH-31813) bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (pythonGH-31812) bpo-46920: Remove code that has no explainer why it was disabled (pythonGH-31814) bpo-46906: Mention native endian in PyFloat_Pack8() doc (pythonGH-31866) bpo-40280: select: Use NULL for empty fdset (pythonGH-31865) CI: Fix patchcheck (pythonGH-31708) bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId (pythonGH-31835) bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API (pythonGH-31837) bpo-39829: Fix `__len__()` is called twice in list() constructor (pythonGH-31816) bpo-47003: Cleanup _overlapped module (pythonGH-31848) bpo-47004: Sync with importlib_metadata 4.11.3. (python#31854) bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820) bpo-46985: Upgrade bundled pip to 22.0.4 (pythonGH-31819) bpo-46805: Add low level UDP socket functions to asyncio (pythonGH-31455) bpo-46995: Deprecate missing asyncio.Task.set_name() for third-party task implementations (pythonGH-31838) bpo-43215: Document Happy Eyeballs args of asyncio.open_connection (pythonGH-24525) ...
@hugovkhugovk mentioned this pull request Mar 17, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

+1 more reviewer

@raghavthind2005raghavthind2005raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hugovk@JelleZijlstra@asvetlov@erlend-aasland@raghavthind2005@the-knights-who-say-ni@bedevere-bot@AlexWaygood