bpo-46841: Add a _Py_SET_OPCODE macro#31780
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
26 tasks
Uh oh!
There was an error while loading. Please reload this page.
markshannon requested changes Mar 9, 2022
Member
markshannon left a comment
markshannon left a comment There was a problem hiding this comment.
The C compiler is allowed to assume that for uint8_t *p1, _Py_CODEUNIT *p2, p1 and p2 don't alias. If you add the special char * cast, then it cannot make that (in this case false) assumption.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Mar 9, 2022
When you're done making the requested changes, leave the comment: |
Member
markshannon commented Mar 9, 2022
LGTM, apart from the missing cast. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we don't modify opargs anymore, this is a cleaner (and slighly more efficient) way of performing this common move.
https://bugs.python.org/issue46841