bpo-46644: Fix test_typing test broken by GH-31151 due to a merge race#31833
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JelleZijlstra requested review from Fidget-Spinner and gvanrossum as code owners
Member
vstinner commented Mar 12, 2022
"fix test" is not a great commit title, it doesn't help future developers who will read commits. Would you mind to elaborate that? Which test? Why was it failing? Is it related to a recent change? etc. |
JelleZijlstra changed the title 
MemberAuthor
JelleZijlstra commented Mar 12, 2022
Good point, how is the new title? |
Member
vstinner commented Mar 12, 2022
Much better. Practical issue: be careful when you click on the Merge button, GitHub uses the commit title and commit message from Git, not the one on the web page. It's confusing. You can fix it with the form open by GitHub. I avoid the automerge label to avoid this trap. |
MemberAuthor
JelleZijlstra commented Mar 12, 2022
Yes, I always read over the commit message when I merge :) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46644