Skip to content

Conversation

@methane
Copy link
Member

@methanemethane commented Aug 24, 2017

(cherry picked from commit a6296d3)

https://bugs.python.org/issue31095

@larryhastings
Copy link
Contributor

Hi, Steve, this is failing on link, can you look in to it?

@methane
Copy link
MemberAuthor

Link error message in AppVeyor:

[00:03:36] Finished generating code [00:03:37] Creating library C:\projects\cpython\PCBuild\win32\_elementtree.lib and object C:\projects\cpython\PCBuild\win32\_elementtree.exp [00:03:37] xmlparse.obj : error LNK2001: unresolved external symbol __Expat_LoadLibrary [C:\projects\cpython\PCbuild\_elementtree.vcxproj] [00:03:37] C:\projects\cpython\PCBuild\win32\_elementtree.pyd : fatal error LNK1120: 1 unresolved externals [C:\projects\cpython\PCbuild\_elementtree.vcxproj] 

@zooba
Copy link
Member

Looks like the pyexpat.vcxproj file was never updated with the last update, and whoever merged that updated didn't run appveyor (or they ignored the failure).

I'll send a PR to update the file. Looks like 3.6 got the change okay, so guessing it's just 3.5.

@zooba
Copy link
Member

See #3751 for the fix.

@methanemethane closed this Sep 25, 2017
@methanemethane reopened this Sep 25, 2017
@larryhastingslarryhastings merged commit 0fcc033 into python:3.5Sep 26, 2017
@methanemethane deleted the backport-a6296d3-3.5 branch December 19, 2017 11:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@methane@larryhastings@zooba@Mariatta@the-knights-who-say-ni@bedevere-bot