Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Mar 19, 2022

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.
(cherry picked from commit 7747384)

Also updated tests to ignore the (new in 3.9) deprecation warnings, the same way they're ignored in 3.10.

https://bugs.python.org/issue47022

Lib/asynchat.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't backport warnings like this, only documentation.

Copy link
MemberAuthor

@hugovkhugovkMar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, dropped changes to .py files, and adjusted the NEWS entry to refer only to docs (and not deprecation warnings).

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannonbrettcannon self-assigned this Mar 21, 2022
…12 (pythonGH-31891) Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.. (cherry picked from commit 7747384) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovkhugovkforce-pushed the backport-7747384-3.9 branch from 66e6bbf to 5419793CompareMarch 22, 2022 09:05
@hugovk
Copy link
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@brettcannonbrettcannon merged commit af341eb into python:3.9Mar 22, 2022
@hugovkhugovk deleted the backport-7747384-3.9 branch March 22, 2022 18:16
@bedevere-bot
Copy link

@brettcannon: Please replace # with GH- in the commit message next time. Thanks!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…12 (pythonGH-31891) (python#31998) Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.. (cherry picked from commit 7747384) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@bedevere-bot@brettcannon@the-knights-who-say-ni