bpo-43224: Implement pickling of TypeVarTuples#32119
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guess who learned a whole bunch about how pickling works :)
Notes:
_BoundVarianceMixinalso contains a key ingredient for pickling of things that use it! I've refactored its__reduce__into a separate mixin for clarity.assertEquala reasonable way of testing this functionality? Am I correct in thinking we do need to test bothassertEqualandassertIsfor TypeVarTuples and unpacked TypeVarTuples?This PR doesn't include implementation of pickling support for unpacked native
tuple; I'll do that in a future PR. (And I guess we'll also need to add tests forcopy?)https://bugs.python.org/issue43224