Skip to content

bpo-47164: Argument Clinic uses _PyCFunction_CAST()#32210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
May 3, 2022
Merged

bpo-47164: Argument Clinic uses _PyCFunction_CAST() #32210

vstinner merged 1 commit into from
May 3, 2022

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Mar 31, 2022•
edited by bedevere-bot
Loading

Replace "(PyCFunction)(void(*)(void))func" cast with
_PyCFunction_CAST(func).

https://bugs.python.org/issue47164

@arhadthedev
Copy link
Member

arhadthedev commented Mar 31, 2022

What to do with yet unmerged PRs that add Argument Clinic stuff (like #32010)? They'll introduce more (PyCFunction)(void(*)(void)).

@vstinner
Copy link
MemberAuthor

vstinner commented Mar 31, 2022

You should ignore this draft PR for now. I'm still thinking about it :-) If there will be a conflict, I will simply regenerate this PR (rerun make clinic).

@vstinnervstinner mentioned this pull request Apr 21, 2022
Closed
@vstinner
gh-91320: Argument Clinic uses _PyCFunction_CAST()
3244477
Replace "(PyCFunction)(void(*)(void))func" cast with _PyCFunction_CAST(func).
@vstinnervstinner marked this pull request as ready for review May 3, 2022 17:53
@vstinner
Copy link
MemberAuthor

vstinner commented May 3, 2022

I rebased my PR.

@vstinner
Copy link
MemberAuthor

vstinner commented May 3, 2022

Example of change:

-{"test_object_converter", (PyCFunction)(void(*)(void))test_object_converter, METH_FASTCALL, test_object_converter__doc__}, +{"test_object_converter", _PyCFunction_CAST(test_object_converter), METH_FASTCALL, test_object_converter__doc__},

@vstinnervstinner merged commit b270b82 into python:mainMay 3, 2022
@vstinnervstinner deleted the clinic_cfunc_cast branch May 3, 2022 18:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettingerrhettingerAwaiting requested review from rhettinger

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

@pgansslepganssleAwaiting requested review from pganssle

@abalkinabalkinAwaiting requested review from abalkin

@tirantiranAwaiting requested review from tiran

@1st11st1Awaiting requested review from 1st1

@asvetlovasvetlovAwaiting requested review from asvetlov

Assignees

No one assigned

Labels

skip newstopic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@arhadthedev@serhiy-storchaka@the-knights-who-say-ni@bedevere-bot