Skip to content

bpo-40280: Detect missing threading on WASM platforms (GH-32352)#32352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiran merged 4 commits into from
Apr 7, 2022
Merged

bpo-40280: Detect missing threading on WASM platforms (GH-32352) #32352

tiran merged 4 commits into from
Apr 7, 2022

Conversation

@tiran
Copy link
Member

@tirantiran commented Apr 6, 2022•
edited
Loading

WASM Emscripten builds for browsers and WASI don't have pthread support. The threading API is stubbed. The changeset adds a test decorator that skips tests which required threading.

https://bugs.python.org/issue40280

@tirantiran changed the title bpo-40280: Detect missing threadingbpo-40280: Detect missing threading on WASM platformsApr 6, 2022
@tirantiran mentioned this pull request Apr 6, 2022
Closed
brettcannon
brettcannon approved these changes Apr 6, 2022
View reviewed changes
@tirantiranforce-pushed the bpo-40280-threading-dlopen branch from 6050f5f to ee4016bCompareApril 7, 2022 06:51
@tirantiran changed the title bpo-40280: Detect missing threading on WASM platformsbpo-40280: Detect missing threading on WASM platforms (GH-32352)Apr 7, 2022
@tirantiran merged commit 2b16a08 into python:mainApr 7, 2022
@tirantiran deleted the bpo-40280-threading-dlopen branch April 7, 2022 07:22
@SimonBiggsSimonBiggsmannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

@encukouencukouAwaiting requested review from encukou

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@brettcannon@the-knights-who-say-ni@bedevere-bot