Skip to content

Conversation

@berkerpeksag
Copy link
Member

@berkerpeksagberkerpeksag commented Nov 24, 2017

Previously, netrc.netrc() was raised an exception if
$HOME is not set.

Authored-By: Dimitri Merejkowsky <dimitri.merejkowsky@tanker.io>

https://bugs.python.org/issue28334

Also add more tests to check that proper exceptions are raised
@berkerpeksagberkerpeksag changed the title [DO NOT MERGE] bpo-28334: fix netrc not working when $HOME is not setbpo-28334: fix netrc not working when $HOME is not setNov 25, 2017
@berkerpeksagberkerpeksag changed the title bpo-28334: fix netrc not working when $HOME is not setbpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrcNov 25, 2017
@berkerpeksagberkerpeksag changed the title bpo-28334: netrc.netrc() now uses os.path.expanduser() to find .netrcbpo-28334: netrc() now uses expanduser() to find .netrc fileNov 25, 2017
@berkerpeksagberkerpeksag merged commit 8d9bb11 into python:masterNov 25, 2017
@berkerpeksagberkerpeksag deleted the 28334-netrc branch November 25, 2017 10:37
@sloriasloria mentioned this pull request Jan 12, 2018
sloria added a commit to sloria/tinynetrc that referenced this pull request Jan 12, 2018
Avoids an exception when $HOME is not set. This behavior matches the behavior in Python 3.7 See python/cpython#4537close#2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@berkerpeksag@the-knights-who-say-ni@bedevere-bot@dmerejkowsky