Skip to content

Conversation

@njsmith
Copy link
Contributor

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449

Here's the correct issue link to confirm: https://bugs.python.org/issue27122

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449
@codecov
Copy link

codecovbot commented Feb 12, 2017

Codecov Report

Merging #47 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #47 +/- ## ========================================== - Coverage 82.37% 82.37% -0.01%  ========================================== Files 1427 1427 Lines 350948 350948 ========================================== - Hits 289089 289083 -6 - Misses 61859 61865 +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2294f3a...a4f3401. Read the comment docs.

@berkerpeksagberkerpeksag merged commit af88e7e into python:masterFeb 12, 2017
berkerpeksag pushed a commit that referenced this pull request Feb 12, 2017
It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449(cherry picked from commit af88e7e)
berkerpeksag pushed a commit that referenced this pull request Feb 12, 2017
It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449 (cherry picked from commit af88e7e)
@berkerpeksag
Copy link
Member

Thanks! I've created #48 and #50 to backport this to maintenance branches.

@MariattaMariatta changed the title Fix comment to point to correct issue #bpo-27122: Fix comment to point to correct issue #Feb 13, 2017
iritkatriel referenced this pull request in iritkatriel/cpython Jul 23, 2021
jaraco pushed a commit that referenced this pull request Dec 2, 2022
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@njsmith@berkerpeksag@Mariatta@the-knights-who-say-ni