Skip to content

Conversation

@zooba
Copy link
Member

@zoobazooba commented Jan 7, 2018

Also fixes bpo-29911, which I forgot about until after I'd already fixed and committed the change.

https://bugs.python.org/issue32507

@zooba
Copy link
MemberAuthor

zooba commented Jan 7, 2018

I can't seem to trigger an AppVeyor build - @zware?

@zware
Copy link
Member

zware commented Jan 7, 2018

I'm going to remove the file whitelist in the AppVeyor config; I think it's causing us more hassle than it's worth. They only check the HEAD commit rather than the difference against the base branch, so since your last commit only changes NEWS entries, AppVeyor doesn't think it should run.

In the meantime, I'll manually start another build here (which you should also be able to do by logging into AppVeyor as the python user). Then again, since it's never run a build on this PR, I can't. Killing the whitelist now...

@zooba
Copy link
MemberAuthor

zooba commented Jan 7, 2018

I tried logging in, but I could only re-run existing PRs. Because it never picked this one up, I couldn't start it.

@zwarezware closed this Jan 7, 2018
@zwarezware reopened this Jan 7, 2018
@zoobazooba merged commit d135f20 into python:masterJan 9, 2018
@zoobazooba deleted the setup-work branch January 9, 2018 08:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zooba@zware@the-knights-who-say-ni@bedevere-bot