Travis CI: run rstlint.py in the docs job#68
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail.
vstinner added docs 
berkerpeksag approved these changes Feb 13, 2017
Contributor
JDLH commented Feb 13, 2017
Thank you for catching this. I authored the trailing spaces in those two lines. It would have helped me to have this check in some sort of |
MemberAuthor
vstinner commented Feb 13, 2017 via email
2017-02-13 21:28 GMT+01:00 Jim DeLaHunt <notifications@github.com>: It would have helped me to have this check in some sort of make test in Doc/Makefile. It would also have helped me to have a reference to this doc testing in https://cpython-devguide.readthedocs.io/docquality.html . You might propose a patch https://github.com/python/devguide or you can now rely on the Travis CI "docs" job for that ;-) |
Member
zware commented Feb 14, 2017
Note that running rstlint is available as |
methane referenced this pull request in methane/cpython Feb 14, 2017
Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail.
methane referenced this pull request in methane/cpython Feb 14, 2017
Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail.
Member
berkerpeksag commented Feb 14, 2017
Good point, opened #96. Thanks! |
vstinner added a commit that referenced this pull request Feb 15, 2017
* Travis CI: run rstlint.py in the docs job (#68) Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail. (cherry picked from commit 2b50186) * Doc/Makefile: set PYTHON to python3 (#124) rstlint.py run by "make check" doesn't support Python 2. "make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't provide the venv module: it's a module of Python 3 standard library. (cherry picked from commit 91b0e7d)
vstinner added a commit that referenced this pull request Feb 16, 2017
* Travis CI: run rstlint.py in the docs job (#68) Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail. (cherry picked from commit 2b50186) * Doc/Makefile: set PYTHON to python3 (#124) rstlint.py run by "make check" doesn't support Python 2. "make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't provide the venv module: it's a module of Python 3 standard library. (cherry picked from commit 91b0e7d) (cherry picked from commit b300c66)
ncoghlan pushed a commit that referenced this pull request Feb 19, 2017
* Add .travis.yml to 3.6 branch * Travis CI: run rstlint.py in the docs job (#68) Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail. * Only run CI checks when appropriate files have changed (#74) Closespython/core-workflow#14 * Use 'make check' instead of 'python3 tools/rstlint.py' (#96)
ncoghlan pushed a commit that referenced this pull request Feb 19, 2017
* Add .travis.yml to 3.5 branch * Only run CI checks when appropriate files have changed (#74) Closespython/core-workflow#14 * Travis CI: run rstlint.py in the docs job (#68) Currently, http://buildbot.python.org/all/buildslaves/ware-docs buildbot is only run as post-commit. For example, bpo-29521 (PR#41) introduced two warnings, unnotified by the Travis CI docs job. Modify the docs job to run toosl/rstlint.py. Fix also the two minor warnings which causes the buildbot slave to fail. * Use 'make check' instead of 'python3 tools/rstlint.py' (#96)
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
The logic in mi_segment_check_free didn't match the logic in mi_segment_reclaim/right_page_reclaimed, which led to a segment being reclaimed that did not have available pages for the appropriate heap. This triggered an assertion error in mi_segment_page_alloc_in. Bug was probably introduced in 45e0ec5Fixes#68
jaraco pushed a commit that referenced this pull request Dec 2, 2022
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
…hat `.readthedocs.yml` will be deprecated) (python#68)
This was referenced Feb 11, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.
Modify the docs job to run toosl/rstlint.py.
Fix also the two minor warnings which causes the buildbot slave to
fail.