bpo-29894: Deprecate returning an instance of complex subclass from __complex__#798
Uh oh!
There was an error while loading. Please reload this page.
Conversation
…_complex__. In a future versions of Python this can be an error.
mention-bot commented Mar 24, 2017
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @tim-one and @theller to be potential reviewers. |
mdickinson left a comment
mdickinson left a comment There was a problem hiding this comment.
There seem to be some changes in complexobject.c that are unrelated to this PR. Apart from that, LGTM.
| Py_DECREF(tmp); | ||
| return NULL; | ||
| } | ||
| assert(PyFloat_Check(tmp)); |
There was a problem hiding this comment.
Did you intend to include this change in this PR?
There was a problem hiding this comment.
It could be included in bpo-26983, but it was not. This PR is good opportunity to make this change since it is related to complex.__new__.
Do you suggest to exclude this change from the PR and make a separate PR.
There was a problem hiding this comment.
No, the change is fine. I just wasn't sure whether you'd intended to include it as part of this PR or not.
4 participants
In a future versions of Python this can be an error.