Skip to content

Conversation

@orsenthil
Copy link
Member

No description provided.

@vstinner
Copy link
Member

You may also update:

Lib/idlelib/help.html:93:<p><strong>Source code:</strong> <a class="reference external" href="https://hg.python.org/cpython/file/3.5/Lib/idlelib/">Lib/idlelib/</a></p> Tools/README:46:(*) A generic benchmark suite is maintained separately at http://hg.python.org/benchmarks/ Tools/importbench/README:6:hg.python.org/benchmarks. 

For benchmarks, please point to the new project: https://github.com/python/performance

By the way, you might use reST syntax for links to enhance formatting.

@@ -222,7 +222,7 @@ releases are announced on the comp.lang.python and comp.lang.python.announce
newsgroups and on the Python home page at https://www.python.org/; an RSS feed of
news is available.

You can also access the development version of Python through Mercurial. See
You can also access the development version of Python through Git. See
https://docs.python.org/devguide/faq.html for details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devguide URL should be updated to http://cpython-devguide.readthedocs.io.
Also, the FAQ has been removed from the Dev Guide, so the section you want is perhaps http://cpython-devguide.readthedocs.io/communication.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/devguide is still correct, but the lack of faq does need to be fixed. Perhaps just remove the /faq.html part.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one correct URL is better.
At least, https://docs.python.org/devguide doesn't switched to github version yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update:
https://docs.python.org/devguide has been updated to github.

At the moment /faq.html is still alive, but will be removed soon (see python/devguide#114)

Let's remove the reference to faq.html here :)

@codecov
Copy link

codecovbot commented Feb 16, 2017

Codecov Report

Merging #8 into master will decrease coverage by -1.03%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8 +/- ## ========================================== - Coverage 83.39% 82.37% -1.03%  ========================================== Files 1367 1427 +60 Lines 344829 350948 +6119 ========================================== + Hits 287563 289083 +1520 - Misses 57266 61865 +4599

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4601c...6d50dde. Read the comment docs.

@orsenthil
Copy link
MemberAuthor

Thanks for the review comments, @Haypo , @Mariatta . I've addressed them

  • I saw only .rst page and restructured, the link
  • We have an opportunity in another PR to .rst the other README's that we maintain the library directory. I'll let this PR just a changing references of hg.python.org to the github repo.

Please review again, if good to go, I am willing to try our merge process with merging this to master and cherrying pick to other active branches.

Thanks!

Copy link
Member

@berkerpeksagberkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that you probably should use needs backport to X.Y labels instead of cherry-pick for X.Y.

@orsenthil
Copy link
MemberAuthor

Thanks @berkerpeksag for your review.

orsenthil added a commit that referenced this pull request Feb 20, 2017
orsenthil added a commit that referenced this pull request Feb 20, 2017
orsenthil added a commit that referenced this pull request Feb 20, 2017
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Sep 1, 2022
8: Add warnings for strings and operations r=ltratt a=nanjekyejoannah This PR adds warnings about: - the unicode type - the `ur` literal - the incompatible `basetring type' - and mixed concat operations for strings Co-authored-by: Joannah Nanjekye <[email protected]>
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
oraluben referenced this pull request in oraluben/cpython Jun 25, 2023
skirpichev referenced this pull request in skirpichev/cpython Dec 4, 2024
DinoV added a commit to DinoV/cpython that referenced this pull request Oct 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@orsenthil@vstinner@methane@berkerpeksag@Mariatta@zware@the-knights-who-say-ni