Skip to content

gh-69093: Add mapping protocol support to sqlite3.Blob#91599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 10 commits into from
Apr 22, 2022
Merged

gh-69093: Add mapping protocol support to sqlite3.Blob #91599

JelleZijlstra merged 10 commits into from
Apr 22, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Apr 16, 2022•
edited
Loading

Originally written by @palaviv in gh-271.

Authored-by: Aviv Palivoda palaviv@gmail.com
Co-authored-by: Erlend E. Aasland erlend.aasland@innova.no

gh-69093

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Apr 16, 2022

Let's land GH-91561 first.

pythongh-69093: Add mapping protocol support to sqlite3.Blob
38b2cdb
Authored-by: Aviv Palivoda <palaviv@gmail.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aaslandforce-pushed the sqlite-blob-add-mapping-protocol branch from a84e0fb to 38b2cdbCompareApril 16, 2022 07:15
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 16, 2022

Let's land GH-91561 first.

Done, could you fix the conflict? I'll also review the code for this one now.

JelleZijlstra
JelleZijlstra reviewed Apr 16, 2022
View reviewed changes
@erlend-aaslanderlend-aasland marked this pull request as draft April 16, 2022 17:56
@erlend-aaslanderlend-aasland marked this pull request as ready for review April 17, 2022 07:53
JelleZijlstra
JelleZijlstra reviewed Apr 17, 2022
View reviewed changes
erlend-aasland
erlend-aasland commented Apr 18, 2022
View reviewed changes
@JelleZijlstraJelleZijlstra self-requested a review April 18, 2022 22:25
JelleZijlstra
JelleZijlstra reviewed Apr 19, 2022
View reviewed changes
@JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-04-14-01-00-31.gh-issue-69093.bm…
9cbc339
…lMwI.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
vstinner
vstinner reviewed Apr 19, 2022
View reviewed changes
@JelleZijlstraJelleZijlstra self-assigned this Apr 22, 2022
@JelleZijlstraJelleZijlstra merged commit 29afb7d into python:mainApr 22, 2022
@erlend-aaslanderlend-aasland deleted the sqlite-blob-add-mapping-protocol branch April 22, 2022 07:44
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Apr 22, 2022

Thanks a lot, Jelle!

@JelleZijlstraJelleZijlstra mentioned this pull request Apr 26, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

@JelleZijlstraJelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@JelleZijlstra@vstinner@bedevere-bot