gh-91768: C API no longer use "const PyObject*" type#91769
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Py_REFCNT(), Py_TYPE(), Py_SIZE() and Py_IS_TYPE() functions argument type is now "PyObject*", rather than "const PyObject*". * Replace also "const PyObject*" with "PyObject*" in functions: * _Py_strhex_impl() * _Py_strhex_with_sep() * _Py_strhex_bytes_with_sep() * Remove _PyObject_CAST_CONST() and _PyVarObject_CAST_CONST() macros * Py_IS_TYPE() can now use Py_TYPE() in its implementation
MemberAuthor
vstinner commented Apr 20, 2022
This change is backward compatible since modified macros cast their argument to |
MemberAuthor
vstinner commented Apr 21, 2022
erlend-aasland requested changes Apr 21, 2022
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
You also need to update the documentation.
MemberAuthor
vstinner commented Apr 21, 2022
Done. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_REFCNT(), Py_TYPE(), Py_SIZE() and Py_IS_TYPE() functions argument
type is now "PyObject*", rather than "const PyObject*".
Replace also "const PyObject*" with "PyObject*" in functions:
Remove _PyObject_CAST_CONST() and _PyVarObject_CAST_CONST() macros
Py_IS_TYPE() can now use Py_TYPE() in its implementation