gh-87452 Making returncode unreliability explicit#92181

zitterbewegung · 2022-05-02T19:14:52Z

We make explicit that the value stored in return code is best returned by poll instead of using the value in return code.

gh-87452: Making returncode unreliability explicit

bedevere-bot · 2022-05-02T19:14:55Z

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

benjaminp · 2022-05-02T19:50:55Z

Thank you for the PR.

I don't think "out-of-date" is the right term here. Either the entire subprocess.Subprocess instance is aware of the exit of the child process and knows the return code, or it doesn't. The first paragraph of the method documentation could perhaps be rearranged to more clearly state the order of events instead of appending another sentence.

…pythongh-87452

benjaminp · 2022-05-02T20:45:14Z

I would propose:

The child return code. Initially ``None``, :attr:`returncode` is set by :meth:`poll` and :meth:`wait` after process termination is observed. ``

Doc/library/subprocess.rst

erlend-aasland · 2022-05-03T18:12:22Z

Please remove the duplicate NEWS entry.

Doc/library/subprocess.rst

Co-authored-by: Oleg Iarygin <dralife@yandex.ru>

erlend-aasland

Again, please remove the duplicate NEWS entry. Also please address Benjamin's remarks.

Doc/library/subprocess.rst

bedevere-bot · 2022-10-14T11:23:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

slateny · 2022-12-06T08:36:03Z

@zitterbewegung Would you still be interested in giving the PR a quick update per the reviews above?

zitterbewegung · 2022-12-06T11:54:41Z

Sorry I can do that.

Wrapping to 79 characters.

netlify · 2022-12-06T14:21:40Z

✅ Deploy Preview for python-cpython-preview ready!

Name	Link
🔨 Latest commit	`41a5d22`
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/638f5503b72cc30008de175b
😎 Deploy Preview	https://deploy-preview-92181--python-cpython-preview.netlify.app/whatsnew/changelog
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Removing newline

zitterbewegung

Fixed word wrap issue
Removed duplicate news entry.

zitterbewegung

Removed trailing whitespace

zitterbewegung · 2022-12-06T15:14:20Z

I have made the requested changes; please review again.

bedevere-bot · 2022-12-06T15:14:24Z

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

zitterbewegung · 2023-04-24T15:47:26Z

@erlend-aasland can this be reviewed?

miss-islington · 2023-04-24T16:46:16Z

Thanks @zitterbewegung for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

erlend-aasland · 2023-04-25T08:43:46Z

Sorry for the delay; thanks Greg for merging. Thanks for the PR, Joshua.

Making unreliability of returncode explicit in documentation.
72565b8

bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 2, 2022

zitterbewegung changed the title ~~Making returncode unreliability explicit~~gh-87452 Making returncode unreliability explicitMay 2, 2022

blurb-itbotand others added 3 commits May 2, 2022 19:52

📜🤖 Added by blurb_it.
8b7c0c3

Rewording with benjaminp and abadger1999 suggestions.
c0dcc5b

Merge remote-tracking branch 'refs/remotes/origin/pythongh-87452' into…
19390f4
…pythongh-87452

zitterbewegungand others added 2 commits May 2, 2022 14:57

Integrating rewording from benjaminp
d62de13

📜🤖 Added by blurb_it.
903ae8d

benjaminp reviewed May 2, 2022
View reviewed changes

Doc/library/subprocess.rst Outdated Show resolvedHide resolved
Doc/library/subprocess.rst Outdated Show resolvedHide resolved

zitterbewegung added 3 commits May 3, 2022 12:25

Merge branch 'python:main' intopythongh-87452
ecbe497

Merge branch 'python:main' intopythongh-87452
c340c8f

Merge branch 'python:main' intopythongh-87452
517dff7

slateny reviewed Oct 13, 2022
View reviewed changes

Doc/library/subprocess.rst Outdated Show resolvedHide resolved

arhadthedev reviewed Oct 13, 2022
View reviewed changes

Doc/library/subprocess.rst Outdated Show resolvedHide resolved

Update Doc/library/subprocess.rst
4adaaab
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>

erlend-aasland requested changes Oct 14, 2022
View reviewed changes

Doc/library/subprocess.rst Outdated Show resolvedHide resolved

bedevere-bot added awaiting changes and removed awaiting review labels Oct 14, 2022

Updating docs for formatting issues.
ca4ea71
Wrapping to 79 characters.

bedevere-bot mentioned this pull request Dec 6, 2022
[doc] Clarify that Popen.returncode does not get auto-set when the process terminates #87452
Closed

Updating for formatting issues
f7e1548
Removing newline

zitterbewegung added 2 commits December 6, 2022 08:25

Removing duplicate entry
6357654

Removing duplicate news file.
708288c

zitterbewegung commented Dec 6, 2022
View reviewed changes

hugovk mentioned this pull request Dec 6, 2022
bpo-37860: re-add netlify.toml to set up deploy previews for docs #92852
Merged

Removing trailing whitespace
41a5d22

zitterbewegung commented Dec 6, 2022
View reviewed changes

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 6, 2022

bedevere-bot requested a review from erlend-aasland December 6, 2022 15:14

furkanonder approved these changes Jan 19, 2023
View reviewed changes

gpshead added 2 commits April 24, 2023 09:30

reword the Popen.returncode text
a6acc97

no need for a NEWS entry on a documentation edit
a4eef80

gpshead self-assigned this Apr 24, 2023

gpshead added skip news needs backport to 3.11 only security fixes labels Apr 24, 2023

gpshead added 2 commits April 24, 2023 09:36

Merge branch 'main' intopythongh-87452
e05f89f

- trailingspace
eb00171

gpshead merged commit 68f5836 into python:mainApr 24, 2023

bedevere-bot removed the awaiting change review label Apr 24, 2023

terryjreedy removed the needs backport to 3.11 only security fixes label Feb 18, 2025

Uh oh!

gh-87452 Making returncode unreliability explicit#92181

gh-87452 Making returncode unreliability explicit #92181

Uh oh!

Conversation

zitterbewegung commented May 2, 2022• edited by terryjreedy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented May 2, 2022

Uh oh!

benjaminp commented May 2, 2022

Uh oh!

benjaminp commented May 2, 2022

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented May 3, 2022

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Oct 14, 2022

Uh oh!

slateny commented Dec 6, 2022

Uh oh!

zitterbewegung commented Dec 6, 2022

Uh oh!

netlifybot commented Dec 6, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for python-cpython-preview ready!

Uh oh!

zitterbewegung left a comment

Choose a reason for hiding this comment

Uh oh!

zitterbewegung left a comment

Choose a reason for hiding this comment

Uh oh!

zitterbewegung commented Dec 6, 2022

Uh oh!

bedevere-bot commented Dec 6, 2022

Uh oh!

zitterbewegung commented Apr 24, 2023

Uh oh!

miss-islington commented Apr 24, 2023

Uh oh!

erlend-aasland commented Apr 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

zitterbewegung commented May 2, 2022•
edited by terryjreedy
Loading

netlifybot commented Dec 6, 2022•
edited
Loading