gh-87390: Fix starred tuple equality and pickling (alt)#92337
Uh oh!
There was an error while loading. Please reload this page.
Conversation
serhiy-storchaka added type-bug 
JelleZijlstra left a comment
JelleZijlstra left a comment There was a problem hiding this comment.
Thanks, this is indeed a better solution.
Could you add tests for pickling starred aliases though? Your new tests only cover equality.
| self.assertEqual(loaded.__origin__, alias.__origin__) | ||
| self.assertEqual(loaded.__args__, alias.__args__) | ||
| self.assertEqual(loaded.__parameters__, alias.__parameters__) | ||
| self.assertEqual(type(loaded), type(alias)) |
There was a problem hiding this comment.
It is the same for types. And I do not want to restart the CI testing for such minor change. 😉
Fidget-Spinner commented May 5, 2022
LGTM. But IMO this needs a news, and like Jelle mentioned more tests (maybe we can take the ones from Mathew's PR and credit him?) |
serhiy-storchaka commented May 5, 2022
The old tests already cover pickling. They were passed, because equality was broken in the same way as pickling. I fixed equality in #92335, but it made pickling tests failing. Since it fixes not yet released code, there is no sense in adding a NEWS entry. It can only confuse readers. |
serhiy-storchaka commented May 5, 2022
Additional tests in Mathew's PR are for the third parameter of GenericAlias. That change is not included in this PR. |
mrahtz commented May 7, 2022
Thanks Serhiy! |
5 participants
It is a simpler alternative of #92249.
#87390