Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-92417: fractions, decimal: Improve docs for alternative constructor methods#92421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the note directive at all. It attracts too much attention. Instead I would add something like "This is a limited version of the :class:`Fraction` constructor which only accepts :class:`~numbers.Integral` or :class:`float`." in plain paragraph.
Replace the method directive with classmethod for class methods.
And the same should be done for Decimal. It would be better to do all this in a single PR.
fractions docs: remove references to Python <3.2fractions, decimal: Improve docs for alternative constructor methodsUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ezio Melotti <[email protected]>
serhiy-storchaka commented May 9, 2022
It would be nice if some math people (like @mdickinson, or @rhettinger, or @tim-one, or @skrah) take a look at it. |
Uh oh!
There was an error while loading. Please reload this page.
mdickinson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick; otherwise, the changes look good to me.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented May 9, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
AlexWaygood commented May 10, 2022
Thanks all for the reviews! I feel like I've received slightly contradictory feedback on this, and it was certainly never my intent to make an aggressive edit, so I've reduced the PR down to a minimal diff which should hopefully be less controversial. I have made the requested changes; please review again. |
bedevere-bot commented May 10, 2022
Thanks for making the requested changes! @serhiy-storchaka, @mdickinson, @rhettinger: please review the changes made to this pull request. |
mdickinson commented May 10, 2022
Agreed. Raymond's assigned this to himself, so I'll duck out at this point and leave this to you and him. |
AlexWaygood commented May 18, 2022
@rhettinger, is there anything more you'd like me to do here? :) (I don't have merge privileges; I'm only a triager.) |
miss-islington commented May 19, 2022
Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
bedevere-bot commented May 19, 2022
GH-92970 is a backport of this pull request to the 3.11 branch. |
…constructor methods (pythonGH-92421) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
…constructor methods (pythonGH-92421) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
bedevere-bot commented May 19, 2022
GH-92971 is a backport of this pull request to the 3.10 branch. |
…uctor methods (GH-92421) (GH-92970) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
…uctor methods (GH-92421) (GH-92971) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
#92417