Skip to content

Conversation

@AlexWaygood
Copy link
Member

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the note directive at all. It attracts too much attention. Instead I would add something like "This is a limited version of the :class:`Fraction` constructor which only accepts :class:`~numbers.Integral` or :class:`float`." in plain paragraph.

Replace the method directive with classmethod for class methods.

And the same should be done for Decimal. It would be better to do all this in a single PR.

@AlexWaygoodAlexWaygood marked this pull request as draft May 8, 2022 05:05
@AlexWaygoodAlexWaygood added the needs backport to 3.11 only security fixes label May 8, 2022
@AlexWaygoodAlexWaygood changed the title gh-92417: fractions docs: remove references to Python <3.2gh-92417: fractions, decimal: Improve docs for alternative constructor methodsMay 8, 2022
@AlexWaygoodAlexWaygood marked this pull request as ready for review May 8, 2022 17:44
Co-authored-by: Ezio Melotti <[email protected]>
@serhiy-storchaka
Copy link
Member

It would be nice if some math people (like @mdickinson, or @rhettinger, or @tim-one, or @skrah) take a look at it.

Copy link
Member

@mdickinsonmdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick; otherwise, the changes look good to me.

@rhettingerrhettinger self-assigned this May 9, 2022
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@AlexWaygood
Copy link
MemberAuthor

Thanks all for the reviews! I feel like I've received slightly contradictory feedback on this, and it was certainly never my intent to make an aggressive edit, so I've reduced the PR down to a minimal diff which should hopefully be less controversial.

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka, @mdickinson, @rhettinger: please review the changes made to this pull request.

@mdickinson
Copy link
Member

I feel like I've received slightly contradictory feedback on this

Agreed. Raymond's assigned this to himself, so I'll duck out at this point and leave this to you and him.

@mdickinsonmdickinson removed their request for review May 10, 2022 18:36
@AlexWaygood
Copy link
MemberAuthor

@rhettinger, is there anything more you'd like me to do here? :)

(I don't have merge privileges; I'm only a triager.)

@ambvambv merged commit 090df84 into python:mainMay 19, 2022
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92970 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
…constructor methods (pythonGH-92421) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
…constructor methods (pythonGH-92421) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot
Copy link

GH-92971 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2022
@AlexWaygoodAlexWaygood deleted the patch-5 branch May 19, 2022 15:29
ambv pushed a commit that referenced this pull request May 19, 2022
…uctor methods (GH-92421) (GH-92970) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
ambv pushed a commit that referenced this pull request May 19, 2022
…uctor methods (GH-92421) (GH-92971) Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 090df84) Co-authored-by: Alex Waygood <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@AlexWaygood@serhiy-storchaka@rhettinger@mdickinson@bedevere-bot@miss-islington@ezio-melotti@ambv