gh-91162: Fix most generic type substitution test cases#92427
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@serhiy-storchaka Darn, I'd just finished this when I realised you'd also been working on the same thing in main...serhiy-storchaka:typing-subst-unpacked. I think the version in my branch uses more helper functions in a way that improves readability, but your version does things in a way that's more consistent with the new design of typing.py - and of course fixes a lot of the C stuff that my branch doesn't touch. How do you want to proceed here?
Quick summary of what's in this PR: