Skip to content

Conversation

@miss-islington
Copy link
Contributor

(cherry picked from commit 5639ea1)

Co-authored-by: Alex Waygood [email protected]

@miss-islington
Copy link
ContributorAuthor

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
ContributorAuthor

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
ContributorAuthor

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
ContributorAuthor

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Apparently I can't delete this comment, but I immediately realized I'd been on the wrong tab and accidentally submitted a review on a backport PR right after submitting it instead of the main one. My fault, sorry.)

@AlexWaygood
Copy link
Member

It looks like there's a chunk of text referring to compatibility with Python <3.2, and workarounds to support Python <2.4, in the description of doctest.EXCEPTION_DETAIL; should that be elided as well? It substantially complicates the description of doctest.IGNORE_EXCEPTION_DETAIL and doesn't seem to be of any use for modern Python, beyond what is already noted in the versionchanged notice.

Let's discuss that over at the issue (#92417) rather than in the comment thread for a backport PR :-)

@CAM-Gerlach
Copy link
Member

Yes, I'd realized immediately after submitting it but couldn't delete my review, so I ended up just editing it instead. Really sorry about that, I'm a doofus.

@AlexWaygood
Copy link
Member

Yes, I'd realized immediately after submitting it but couldn't delete my review, so I ended up just editing it instead. Really sorry about that, I'm a doofus.

No reason to be sorry! I'm sure miss-islington appreciates the review :-)

@rhettinger
Copy link
Contributor

Please don't backport these. That is only appropriate for a bug fix.

@miss-islingtonmiss-islington deleted the backport-5639ea1-3.9 branch May 9, 2022 08:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewdocsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington@AlexWaygood@CAM-Gerlach@rhettinger@bedevere-bot