Skip to content

gh-91491: Complete Whats New in 3.11 for typing#92708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 5 commits into from
May 19, 2022
Merged

gh-91491: Complete Whats New in 3.11 for typing #92708

JelleZijlstra merged 5 commits into from
May 19, 2022

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented May 12, 2022

Fixes#91491

@bedevere-botbedevere-bot added docs Documentation in the Doc dir awaiting core review labels May 12, 2022
@JelleZijlstraJelleZijlstra marked this pull request as draft May 12, 2022 03:07
hauntsaninja
hauntsaninja reviewed May 12, 2022
View reviewed changes
Fidget-Spinner
Fidget-Spinner reviewed May 12, 2022
View reviewed changes
Doc/whatsnew/3.11.rst
Comment on lines +754 to +756
* Loosen runtime requirements for type annotations by removing the callable
check in the private ``typing._type_check`` function. (Contributed by
Gregory Beauregard in :gh:`90802`.)
Copy link
Member

@Fidget-SpinnerFidget-SpinnerMay 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really include this? It's a private undocumented function (though David's recent bug report suggested to me otherwise).

Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraMay 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's already spawned a bug report, it's likely that other users will run into this change, so I think it's important to include.

Copy link
Member

@Fidget-SpinnerFidget-SpinnerMay 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed then. Could you please add a notice strongly discouraging users from using it too? We might as well try to dissuade users though it might be in vain :).

This function is for internal use only and is **unstable** and may change across versions. Please do not use this function. Instead, we recommend implementing this with your own code.

Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraMay 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels like a bit much for the What's New document. We should say what changed, but I don't think we need more than that.

@JelleZijlstra@hauntsaninja
Update Doc/whatsnew/3.11.rst
c0d95b4
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@JelleZijlstraJelleZijlstra marked this pull request as ready for review May 12, 2022 14:22
AlexWaygood
AlexWaygood reviewed May 12, 2022
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

AlexWaygood
AlexWaygood reviewed May 17, 2022
View reviewed changes
@JelleZijlstra@AlexWaygood
Update Doc/whatsnew/3.11.rst
c242df1
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstraJelleZijlstra added the needs backport to 3.11 only security fixes label May 19, 2022
@JelleZijlstraJelleZijlstra merged commit 6b51773 into python:mainMay 19, 2022
@miss-islington
Copy link
Contributor

miss-islington commented May 19, 2022

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 19, 2022

Sorry @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6b51773afd5658e15d23ce220f66fcc39c02dcae 3.11

@JelleZijlstraJelleZijlstra deleted the whatsnew branch May 19, 2022 14:07
@JelleZijlstraJelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 19, 2022
@miss-islington
Copy link
Contributor

miss-islington commented May 19, 2022

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@JelleZijlstra@miss-islington
pythongh-91491: Complete Whats New in 3.11 for typing (pythonGH-92708)
fdb36c2
FixespythonGH-91491 Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 6b51773) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
@bedevere-bot
Copy link

bedevere-bot commented May 19, 2022

GH-92958 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request May 19, 2022
@miss-islington@JelleZijlstra
gh-91491: Complete Whats New in 3.11 for typing (GH-92708)
611d43c
FixesGH-91491 Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> (cherry picked from commit 6b51773) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@JelleZijlstraJelleZijlstra

Labels

docsDocumentation in the Doc dirskip newstopic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add typing to 3.11 What's New

6 participants

@JelleZijlstra@miss-islington@bedevere-bot@hauntsaninja@Fidget-Spinner@AlexWaygood