Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-93851: Fix all broken links in Doc/#93853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
d34731f9a20620bd5d3d2c8fa76ee895a5f877513b17aa6116cdf99a73ae7029f6ced48665a44File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,7 +4,7 @@ | ||
| .. module:: importlib.resources | ||
| :synopsis: Package resource reading, opening, and access | ||
| **Source code:** :source:`Lib/importlib/resources.py` | ||
| **Source code:** :source:`Lib/importlib/resources/__init__.py` | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to myself: leave it out while backporting. | ||
| -------------- | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,6 +3,10 @@ | ||
| {% if daily is defined %} | ||
| {% set dlbase = pathto('archives', 1) %} | ||
| {% else %} | ||
| {# | ||
| The link below returns HTTP 404 until the first related alpha release. | ||
| This is expected; use daily documentation builds for CPython development. | ||
| #} | ||
| {% set dlbase = 'https://docs.python.org/ftp/python/doc/' + release %} | ||
| {% endif %} | ||
ned-deily marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading. Please reload this page. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -17,7 +17,7 @@ re-used. | ||
| .. deprecated:: 3.6 | ||
| ``pyvenv`` was the recommended tool for creating virtual environments for | ||
| Python 3.3 and 3.4, and is `deprecated in Python 3.6 | ||
| <https://docs.python.org/dev/whatsnew/3.6.html#deprecated-features>`_. | ||
| <https://docs.python.org/dev/whatsnew/3.6.html#id8>`_. | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The link now points to an exact changelog line instead of the whole section. | ||
| .. versionchanged:: 3.5 | ||
| The use of ``venv`` is now recommended for creating virtual environments. | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1647,7 +1647,7 @@ for secure (encrypted, authenticated) internet connections: | ||||||
| * The :func:`ssl.wrap_socket` constructor function now takes a *ciphers* | ||||||
| argument. The *ciphers* string lists the allowed encryption algorithms using | ||||||
| the format described in the `OpenSSL documentation | ||||||
| <https://www.openssl.org/docs/manmaster/man1/ciphers.html#CIPHER-LIST-FORMAT>`__. | ||||||
| <https://www.openssl.org/docs/man1.0.2/man1/ciphers.html#CIPHER-LIST-FORMAT>`__. | ||||||
| * When linked against recent versions of OpenSSL, the :mod:`ssl` module now | ||||||
| supports the Server Name Indication extension to the TLS protocol, allowing | ||||||
| @@ -2593,10 +2593,12 @@ Changes to Python's build process and to the C API include: | ||||||
| longer used and it had never been documented (:issue:`8837`). | ||||||
| There were a number of other small changes to the C-API. See the | ||||||
| :source:`Misc/NEWS` file for a complete list. | ||||||
| Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_ | ||||||
MemberAuthor
| ||||||
| Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_ | |
| `Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_ |
For some reason, gh-94078 backport is the only one that caught this typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly because it was using the old docs checker script as opposed to Sphinx-Lint. Could you verify whether the latest Sphinx-Lint 0.6.6 catches this case, and if not, could you report it upstream? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it really isn't great that we're regressing from using a dedicated role to hardcoded links...but hopefully the new suite of roles we're developing for this will replace this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you verify whether the latest Sphinx-Lint 0.6.6 catches this case [...]
I ran sphinx-lint 0.6.7 and it caught the typo successfully:
C:\Users\oleg\Documents\dev\notmine\cpython>sphinx-lint Doc/whatsnew/3.2.rst Doc/whatsnew/3.2.rst:54: missing backtick before hyperlink reference: 'Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_'. (hyperlink-reference-missing-backtick) So I hope that adoption of sphinx-lint will eliminate such sporadic discoveries.
Uh oh!
There was an error while loading. Please reload this page.