[3.11] gh-93820: Fix copy() regression in enum.Flag (GH-93876)#93886
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pythonGH-26658 introduced a regression in copy / pickle protocol for combined `enum.Flag`s. `copy.copy(re.A | re.I)` would fail with `AttributeError: ASCII|IGNORECASE`. `enum.Flag` now has a `__reduce_ex__()` method that reduces flags by combined value, not by combined name. (cherry picked from commit 05b32c1) Co-authored-by: Christian Heimes <christian@python.org>
ContributorAuthor
miss-islington commented Jun 16, 2022
Status check is done, and it's a success ✅ . |
tiran approved these changes Jun 16, 2022
ContributorAuthor
miss-islington commented Jun 16, 2022
@tiran: Status check is done, and it's a success ❌ . |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-26658 introduced a regression in copy / pickle protocol for combined
enum.Flags.copy.copy(re.A | re.I)would fail withAttributeError: ASCII|IGNORECASE.enum.Flagnow has a__reduce_ex__()method that reduces flags bycombined value, not by combined name.
(cherry picked from commit 05b32c1)
Co-authored-by: Christian Heimes christian@python.org