[3.11] GH-93516: Speedup line number checks when tracing. (GH-93763)#94023
Uh oh!
There was an error while loading. Please reload this page.
Conversation
The ABI breakage is not really a break, as the new field is inserted (almost) at the end, after any other fields used in C extensions. |
| self.write(f".co_name = {co_name},") | ||
| self.write(f".co_qualname = {co_qualname},") | ||
| self.write(f".co_linetable = {co_linetable},") | ||
| self.write("._co_linearray = NULL,") |
There was a problem hiding this comment.
Sorry, unrelated question, but does this mean I need to add the field from my _co_code change here too?
There was a problem hiding this comment.
Technically, no. C will initialize any fields not explicitly mentioned to zero.
I think it is good practice to be explicit, though.
pablogsal commented Jun 21, 2022
I will regenerate the ABI in this PR |
pablogsal commented Jun 21, 2022
@markshannon I cannot push to the remote repo, could you please ensure the "allow pushes from maintainers checkbox is activated on the right column"? |
markshannon commented Jun 21, 2022
There is no "allow pushes from maintainers" checkbox. |
markshannon commented Jun 22, 2022
Closing in favour of #94127 to allow edits. |
4 participants
Backport of #93763