Skip to content

Conversation

@encukou
Copy link
Member

@encukouencukou commented Jun 23, 2022

The ABI is only checked in maintenance branches, but it is sometimes useful to generate it for main.

  • The resulting file should be ignored in main.
  • The file should be created if it doesn't exist.

If this goes in, some “make maintenance branch” RM checklist/script will need a “remove Doc/data/python*.abi from .gitignore” entry.

@pablogsal, this could be combined with #94135

The ABI is only checked in maintenance branches, but it is sometimes useful to generate it for main. - The resulting file should be ignored in main. - The file should be created if it doesn't exist.
@arhadthedev
Copy link
Member

remove Doc/data/python*.abi from .gitignore

Calling git add with --force allows to keep gitignore unmodified:

-f, --force
Allow adding otherwise ignored files.

@encukou
Copy link
MemberAuthor

Yes, but AFAIK there are then warnings when you update a file that's ignored but tracked anyway.
The maintenance branches need some changes anyway – adding the CI check, at least – so I asume it's not a big burden to update .gitignore.

@pablogsal
Copy link
Member

@pablogsal, this could be combined with #94135

@encukou do you want me to add this change to that PR?

@encukou
Copy link
MemberAuthor

Go ahead!

@encukouencukou closed this Jun 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou@arhadthedev@pablogsal@bedevere-bot