Skip to content

gh-93096: Remove python -m base64 -t#94230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 8 commits into from
Jul 2, 2022
Merged

gh-93096: Remove python -m base64 -t#94230

corona10 merged 8 commits into from
Jul 2, 2022

Conversation

@arhadthedev
Copy link
Member

@arhadthedevarhadthedev commented Jun 24, 2022•
edited
Loading

test_base64.LegacyBase64TestCase.test_encodebytes/test_decodebytes is a more advanced version of the removed CLI argument.

The removed feature brings no benefit to an end user (unlike the rest of python -m base64).

@arhadthedevarhadthedev mentioned this pull request Jun 24, 2022
Open
27 tasks
corona10
corona10 requested changes Jul 2, 2022
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jul 2, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10
corona10 reviewed Jul 2, 2022
View reviewed changes
Lib/base64.py Outdated
defmain():
"""Small main program"""
importsys, getopt
usage="""usage: %s [-h|-d|-e|-u|-t] [file|-]
Copy link
Member

@corona10corona10Jul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we update usage to use f-string?

Copy link
MemberAuthor

@arhadthedevarhadthedevJul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Should I go further and convert it to argparse?

@arhadthedev
Copy link
MemberAuthor

arhadthedev commented Jul 2, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Jul 2, 2022

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10
corona10 approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10corona10 merged commit 7db1d2e into python:mainJul 2, 2022
@arhadthedevarhadthedev deleted the remove-base64-cli branch July 2, 2022 06:58
This was referenced Mar 6, 2023
Closed
Merged
@arhadthedevarhadthedev mentioned this pull request Apr 2, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arhadthedev@bedevere-bot@corona10