gh-87347: Fix PyObject_NEW() regression#94234
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Jun 24, 2022
cc @corona10 |
erlend-aasland approved these changes Jun 24, 2022
Modules/_testcapimodule.c Outdated
Contributor
There was a problem hiding this comment.
Looks like leftovers from an early revision. I'm sure Victor will remove it before merging.
MemberAuthor
There was a problem hiding this comment.
Oops, I forgot about it. That's why reviews are great :-) I removed this unused macro. I used if+goto instead of the macro.
Don't add parenthesis around the type parameter. Add unit tests on PyObject_NEW() and similar functions.
kumaraditya303 approved these changes Jun 26, 2022
MemberAuthor
vstinner commented Jun 26, 2022
Merged, thanks for reviews! |
MemberAuthor
vstinner commented Jun 27, 2022
Oops, my test leaks 4 references: I wrote PR #94330 to fix it. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't add parenthesis around the type parameter.
Add unit tests on PyObject_NEW() and similar functions.