Skip to content

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Jun 28, 2022

Since 3.11 we have moved some low level operations to the bytecode which mean that frames can be in a partially constructed state during GC, or other operations that could expose them to Python code (or third party C code).

We already avoid tracing any instructions before the first RESUME when executing a frame.
This PR prevents creating a frame object before the first RESUME has been reached.

@markshannonmarkshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 28, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 5043a8b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 28, 2022
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@markshannon
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@markshannonmarkshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 939769c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@markshannonmarkshannon merged commit 544531d into python:mainJul 1, 2022
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2022
… complete. (pythonGH-94371) (cherry picked from commit 544531d) Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 1, 2022
@bedevere-bot
Copy link

GH-94482 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this pull request Jul 4, 2022
…t complete. (GH-94371) (#94482) Co-authored-by: Mark Shannon <mark@hotpy.org>
@markshannonmarkshannon deleted the no-frame-object-too-early branch September 26, 2023 12:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon@bedevere-bot@miss-islington@pablogsal@kumaraditya303