[3.10] gh-84753: Make inspect.iscoroutinefunction() work with AsyncMock (GH-94050)#94461
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pythonGH-94050) The inspect version was not working with unittest.mock.AsyncMock. The fix introduces special-casing of AsyncMock in `inspect.iscoroutinefunction` equivalent to the one performed in `asyncio.iscoroutinefunction`. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 4261b6b) Co-authored-by: Mehdi ABAAKOUK <sileht@sileht.net>
ContributorAuthor
miss-islington commented Jun 30, 2022
ContributorAuthor
miss-islington commented Jun 30, 2022
Status check is done, and it's a success ✅ . |
1 similar comment
ContributorAuthor
miss-islington commented Jun 30, 2022
Status check is done, and it's a success ✅ . |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspect version was not working with unittest.mock.AsyncMock.
The fix introduces special-casing of AsyncMock in
inspect.iscoroutinefunctionequivalent to the oneperformed in
asyncio.iscoroutinefunction.Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 4261b6b)
Co-authored-by: Mehdi ABAAKOUK sileht@sileht.net