Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase#94593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
graingert commented Jul 6, 2022
Can you copy over the test cases from my PR? |
kumaraditya303 commented Jul 6, 2022
I added a test. |
asvetlov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
kumaraditya303 commented Jul 6, 2022
Thanks for the reviews! |
graingert commented Jul 6, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I think the docs should describe this change: |
kumaraditya303 commented Jul 6, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This would complicate things for an average user about how policy registry works. The existing docs is clear |
miss-islington commented Jul 6, 2022
Thanks @kumaraditya303 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commented Jul 6, 2022
GH-94608 is a backport of this pull request to the 3.11 branch. |
…ncioTestCase (pythonGH-94593) (cherry picked from commit 14fea6b) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.