Skip to content

gh-94801: Use custom flags to check for headers and libs#94802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiran merged 2 commits into from
Jul 15, 2022
Merged

gh-94801: Use custom flags to check for headers and libs #94802

tiran merged 2 commits into from
Jul 15, 2022

Conversation

@tiran
Copy link
Member

@tirantiran commented Jul 13, 2022•
edited by miss-islington
Loading

@tirantiran added the needs backport to 3.11 only security fixes label Jul 13, 2022
@tiran
Copy link
MemberAuthor

tiran commented Jul 13, 2022

I addressed most places. The code now correctly triggers Emscripten's embuilder to download and install ports.

@tirantiran marked this pull request as ready for review July 13, 2022 21:30
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 14, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 7bb04f3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
erlend-aasland
erlend-aasland approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@tirantiran added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 15, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 15, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

1 similar comment
@bedevere-bot
Copy link

bedevere-bot commented Jul 15, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 15, 2022
@tirantiran merged commit 944ff8c into python:mainJul 15, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jul 15, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tirantiran deleted the gh-94801-cflags branch July 15, 2022 12:48
@miss-islington
Copy link
Contributor

miss-islington commented Jul 15, 2022

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 944ff8c57c9e8ff5a5bd18925070ddb1504490ab 3.11

tiran added a commit to tiran/cpython that referenced this pull request Jul 15, 2022
@tiran
[3.11]pythongh-94801: Use custom flags to check for headers and libs (…
96e6bec
…pythonGH-94802). (cherry picked from commit 944ff8c) Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 15, 2022

GH-94881 is a backport of this pull request to the 3.11 branch.

tiran added a commit that referenced this pull request Jul 18, 2022
@tiran
[3.11]gh-94801: Use custom flags to check for headers and libs (GH-9…
30412d9
…4802) (GH-94881) Co-authored-by: Christian Heimes <christian@python.org>
@tirantiran mentioned this pull request Jul 18, 2022
Merged
@zaniebzanieb mentioned this pull request Dec 30, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

@tirantiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@miss-islington@erlend-aasland